Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list RPC method #3311

Closed
jtcohen6 opened this issue May 3, 2021 · 1 comment · Fixed by #3384
Closed

Add list RPC method #3311

jtcohen6 opened this issue May 3, 2021 · 1 comment · Fixed by #3384
Assignees
@iknox-fa
Labels
enhancement New feature or request rpc Issues related to dbt's RPC server
Milestone
Margaret Mead

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented May 3, 2021 •
edited
Loading

picks up from #3269

Add a list method to the RPC server.

Can we run it synchronously / single-threaded, to avoid delays associated with polling? Running this sync won't be in scope for the initial effort. The most important thing is wiring it up and making sure the inputs + outputs match the dbt ls CLI command.
@jtcohen6 jtcohen6 added enhancement New feature or request rpc Issues related to dbt's RPC server labels May 3, 2021
@jtcohen6 jtcohen6 added this to the Margaret Mead milestone May 3, 2021
@jtcohen6
Copy link
Contributor Author

Requirements:

  • Supported by RPC in async mode
  • Not blocking other RPC requests (does this mean the list task needs to supported multiple threads?)

@iknox-fa iknox-fa mentioned this issue May 21, 2021
Merged
4 tasks
@leahwicz leahwicz mentioned this issue May 24, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iknox-fa iknox-fa

Labels
enhancement New feature or request rpc Issues related to dbt's RPC server
Projects
None yet
Milestone
Margaret Mead
Development

Successfully merging a pull request may close this issue.

Add ls to RPC server dbt-labs/dbt-core
2 participants
@jtcohen6 @iknox-fa