Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package <-> dbt version compatibility #581

Closed
cmcarthur opened this issue Nov 6, 2017 · 1 comment
Closed

package <-> dbt version compatibility #581

cmcarthur opened this issue Nov 6, 2017 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@cmcarthur
Copy link
Member

cmcarthur commented Nov 6, 2017

right now, packages have no metadata about which version of dbt is required. all of the logic is built out for working with versions, it just needs to get re-used to manage dbt <> package version relationships.

Example:

dbt_project.yml


name: my_project
version: 1.0.0

require-dbt-version: "<0.13.0"

The require-dbt-version config should be a semver specification as defined here: https://github.com/fishtown-analytics/dbt/blob/9398ccd82020457ced76bc460ec9d68121d09ce4/dbt/semver.py#L31

When dbt runs a project, it should check that the version of dbt is compatible with the required version for the project. This check should also apply to any packages included as dependencies.

dbt should also provide a CLI arg to ignore this check. If the flag (eg. --no-version-check) is provided, then dbt should run the project as normal. If a package is incompatible with a given version of dbt and --no-version-check is not provided, dbt should show the following error message and then exit.

This version of dbt is not supported with the '{package}' package.
  Installed version of dbt: {dbt version}
  Required version of dbt for '{package}': {version spec}

Check the requirements for the '{package}' package, or run dbt again with --no-version-check
@cmcarthur cmcarthur added this to the Package Management milestone Nov 6, 2017
@cmcarthur cmcarthur added the enhancement New feature or request label Nov 6, 2017
@drewbanin drewbanin modified the milestones: Package Management, 0.9.2 Jan 12, 2018
@cmcarthur cmcarthur modified the milestones: Package Management, 0.10.2 Apr 26, 2018
@jthandy jthandy added this to the Stephen Girard milestone Oct 25, 2018
@drewbanin drewbanin modified the milestones: Stephen Girard, Grace Kelly Nov 2, 2018
@cmcarthur cmcarthur modified the milestones: Grace Kelly, Stephen Girard Nov 28, 2018
@beckjake beckjake self-assigned this Dec 6, 2018
beckjake added a commit that referenced this issue Dec 14, 2018
…version-compatibility

package dbt version compatibility (#581)
@beckjake
Copy link
Contributor

Closed by #1178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants