-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves dbt --help documentation #1060
Improves dbt --help documentation #1060
Conversation
This is great @mikekaminsky! Looks like there are some conflicts to resolve, but this will be a really great addition. What do you think about linking to docs.getdbt.com? We could link to specific sections for subcommands (eg. dbt run), or just plaster a big link in the main help header.
There's a great article on CLI design that @jthandy just turned me on to here: https://medium.com/@jdxcode/12-factor-cli-apps-dd3c227a0e46 I was thinking of implementing the Thanks for submitting this - it's really great! |
Thanks @drewbanin! I just fixed the conflicts and added the link to the docs in the description. I think adding links for very command would be over-kill (plus, not actually that useful in a CLI). I think the |
Thanks @mikekaminsky! I don't see the docs link in the diff here -- any chance it got lost in a merge? |
@drewbanin bizarre! Must have lost it in the git somewhere. Updated now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor nitpick, then LGTM! This is going to be a really great addition to dbt -- thanks for contributing!
dbt/main.py
Outdated
formatter_class=argparse.RawTextHelpFormatter, | ||
description="An ELT tool for managing your SQL " | ||
"transformations and data models." | ||
"\nFor more documentation on these comands, visit: " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i so hate to do this to you, but I think this should say "commands" :)
@drewbanin good catch! Fixed. |
Thanks @mikekaminsky! This will be going out in our next release, 0.12.0! |
Addresses #1058
New and improved CLI help docs:
Note: I'm not attached to any of this copy / verbiage. Please pile on if you have improvements.