Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: macros #1348

Merged
Merged

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Mar 12, 2019

Fixes #1308

Add an optional "macros" parameter to rpc calls (compile and run). The parameter name is "macros" and the data should be base64-encoded text that when decoded, represents a coherent macro sql file. You can specify as many macros as you would like, and passed macros override those in the current project for the current API call.

@beckjake beckjake requested a review from drewbanin March 12, 2019 00:28
@cmcarthur
Copy link
Member

@beckjake this looks great to me. super happy with how simple it was to wire this up.

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@beckjake beckjake merged commit c1c09f3 into feature/rpc-improve-dbt-exceptions Mar 12, 2019
@beckjake beckjake deleted the feature/rpc-with-macros branch March 12, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants