dbt ls command (#467) #1436
Merged
dbt ls command (#467) #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 1, 2019 07:11
All tasks now have a 'pre_init_hook' classmethod, called by main - runs after args are parsed, before anything else
drewbanin
reviewed
May 6, 2019
There was a problem hiding this comment.
One minor comment below, and some feedback after playing around with this a little more. There might be merit to supporting a --models flag which
- specifies the
--selectargument and - constrains the
--resource-typeargument tomodels
Because --models implies both a resource type and a selector, I think these flags should be mutually exclusive. That is: if --models is supplied, then neither --select nor --resource-type can be supplied.
This is motivated by my typing dbt ls --models ... repeatedly in testing this PR out :)
Do you buy this?
core/dbt/main.py
Outdated
| required=False, | ||
| nargs='+', | ||
| help="Specify the nodes to select.", | ||
| dest='models' |
There was a problem hiding this comment.
can you change this to selection or selector? It renders as
-s MODELS [MODELS ...], --select MODELS [MODELS ...]
in --help
Fixed error logging to display errors in dbt ls Add models flag Make all of models, select, exclude have a metavar of 'SELECTOR' for -h
drewbanin
approved these changes
May 9, 2019
|
Oops, I did resolve those! Well, I think I did - pretty sure the old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #467
One change I had to make: the
original_file_pathnow points at the actual original file path, rather than a weird combination of the compiled path + the root of the search that sometimes doesn't exist. Models and such retained their original correct paths.