Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postgres mixedcase database (#1800) #1936

Merged
merged 3 commits into from
Nov 20, 2019

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Nov 19, 2019

Fixes #1800

Fix mixed-case database handling on postgres (and presumably redshift) with two changes:

  • when listing the catalog, do not re-case the database but instead render it as given
  • use the information_schema.database value for the built relation rather than the lowercased form

I disabled the new test on Windows, it's just too painful to play run-break-fix on configuring stuff without a local Windows development env to test on.

@cla-bot cla-bot bot added the cla:yes label Nov 19, 2019
@beckjake beckjake changed the title Fix/postgres mixedcase database Fix postgres mixedcase database (#1800) Nov 19, 2019
@beckjake beckjake force-pushed the fix/postgres-mixedcase-database branch from e754d4d to 24247dd Compare November 19, 2019 17:46
@beckjake beckjake marked this pull request as ready for review November 19, 2019 17:47
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Can you update the changelog accordingly?

Under the pg/redshift heading:

- Fix for internal errors when run against mixed-case logical databases (#1800, #1936)

Pending that, approved

@beckjake
Copy link
Contributor Author

I'm going to merge this even though snowflake timed out on Windows - it's just information_schema queries taking forever again.

@beckjake beckjake merged commit 67d499e into dev/louisa-may-alcott Nov 20, 2019
@beckjake beckjake deleted the fix/postgres-mixedcase-database branch November 20, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pg/redshift database verification case-insensitive
2 participants