Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generated_at instead of datetime.utcnow() #1988

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Use generated_at instead of datetime.utcnow() #1988

merged 1 commit into from
Dec 6, 2019

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Dec 6, 2019

Small copy-paste error, but I think we want to use the generated_at here.

@cla-bot cla-bot bot added the cla:yes label Dec 6, 2019
beckjake
beckjake approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, I've kicked off the tests for this! I thought there was an issue about something that sounded related to this, but I can't find it - perhaps it was only reported in slack.

@beckjake beckjake merged commit 564cc22 into dbt-labs:dev/0.15.1 Dec 6, 2019
@Fokko Fokko deleted the fd-use-generated-at branch February 5, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckjake beckjake beckjake approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fokko @beckjake