add oauth authentication to snowflake adapter (#2050) #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
reviewed
Jan 24, 2020
There was a problem hiding this comment.
This looks great! We can test this out with our own Snowflake instance, but I don't think it's a good idea to make it an automated test at present. I can give this a spin manually, but in the meantime, can you make the base branch for this one dev/0.15.2? That was my bad - I should have noted it in the issue.
I'll follow up here when I've done some functional testing
beckjake
force-pushed
the
feature/snowflake-oauth
branch
from
d463e8c
to
e7d2221
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2050
Add oauth support and a unit test.
I don't have any clever way to integration test this (without setting up oauth I guess), but based on my reading of snowflake's docs, this unit test demonstrates that dbt does the right thing.