Feature: node depends_on.macros (#2082) #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
changed the base branch from
feature/contexts-redux
to
dev/barbara-gittings
Clean up macro generation a bit
beckjake
force-pushed
the
feature/macro-depends-on
branch
from
91f1b4f
to
2049665
Compare
drewbanin
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
This looks excellent - I love the way you implemented the capturing of immediate macro calls here. I feared that this would be really gross/complicated, but it's so simple and pretty :)
I'll implement the corresponding docs functionality in dbt-labs/dbt-docs#61
Ship this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2082
Add directly called macros into nodes'
depends_onlisting. Keep track of the call stack in thread-local storage for each model invocation indbt compile, and record all the 0-depth nodes independs_on.macros.There is some legacy code that purports to capture macros (the
ParserMacroCapturestuff). I messed with it a bit and as far as I can tell the relevant code (__call__) is never even called, so I went with this route because I'm confident it actually works...