Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rev the bigquery minimum versions to a big number (#2233) #2249

Merged
merged 3 commits into from
Mar 26, 2020

Conversation

beckjake
Copy link
Contributor

resolves #2233

Description

I raised the lower bound on most of the bigquery dependencies to whatever the current version I have installed is - I'm sure this will break someone's workflow, but hopefully this will avoid us having to deal with it too often, and hopefully prevent us from getting surprised by requirements updates that add a feature we were inadvertently relying on.

While I was in here I also bumped the version and fixed a bug in the unit tests where they would fail if the version number was a final release version (but not if they were an alpha/beta/rc)

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Mar 26, 2020
@beckjake beckjake requested a review from drewbanin March 26, 2020 17:02
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@beckjake beckjake merged commit 386895f into dev/0.16.1 Mar 26, 2020
@beckjake beckjake deleted the fix/rev-google-lower-bound branch March 26, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants