Return proper error message when empty profiles.yml is used for project #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumanau7
force-pushed
the
fix/return_proper_msg_for_empty_profile
branch
from
1a6af7b
to
4f88355
Compare
|
@drewbanin Request for review. |
drewbanin
reviewed
Apr 6, 2020
There was a problem hiding this comment.
Thanks for opening this PR @sumanau7! This is a good and positive change, but I think there's also another closely related change for us to make here too.
Right now, if you have the following files:
# dbt_project.yml
name: debug
version: 1.0.0
profile: my_profile
# profiles.yml
my_profile:
dbt will also fail hard with an unhelpful error:
argument of type 'NoneType' is not iterable
Can we also address that case here too? This is the proximate bug described in #2292, but I am thrilled that you fixed another issue in here too!
drewbanin
reviewed
Apr 6, 2020
sumanau7
force-pushed
the
fix/return_proper_msg_for_empty_profile
branch
from
a4240aa
to
c2dc216
Compare
beckjake
approved these changes
Apr 6, 2020
sumanau7
force-pushed
the
fix/return_proper_msg_for_empty_profile
branch
from
21da349
to
b78f515
Compare
|
Updated Changelog. |
beckjake
reviewed
Apr 8, 2020
sumanau7
force-pushed
the
fix/return_proper_msg_for_empty_profile
branch
from
f55e2ed
to
35b43e9
Compare
|
Another great PR, thanks for contributing to dbt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2292
Description
Return proper error message when profiles.yaml is empty
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.