use "show objects in schema" (#2174) #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Locally I saw a significant performance improvement on the test suite: The time to run all snowflake tests went from 663s to 545s! Real dbt projects will have a much lower proportion of |
drewbanin
approved these changes
Apr 16, 2020
| # if the schema doesn't exist, we just want to return. | ||
| # Alternatively, we could query the list of schemas before we start | ||
| # and skip listing the missing ones, which sounds expensive. | ||
| if 'Object does not exist' in str(exc): |
There was a problem hiding this comment.
this is a really good call!
|
That change was just a changelog merge conflcit, merging now. |
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2174
Description
Use "show terse objects in schema" to implement list_relations_without_caching, instead of the information schema.
I added a try/except to catch the error when the schema doesn't exist and return an empty list - this emulates the old behavior.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.