log 'depends_on_nodes' node attribute in the log record 'extra' field #2341
Conversation
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @dcereijodo |
|
Thanks for opening this issue @dcereijodo! Tagging @beckjake to review. Before we get into a proper review though - do you mind resubmitting the CLA form? I see that the address entered into the form was only partially entered. We're going to need a complete mailing address in order to record the CLA submission to get this PR merged. Thanks for your help! |
There was a problem hiding this comment.
Hi @dcereijodo, this looks like a great change to me - thanks for contributing!
Can you please add links to this issue/PR in the changelog under Features similar to the other entries? For the text, something like "Add a 'depends_on_nodes' attribute to log record extra field" should be great.
Also please add your username and a link to this PR to the contributors list so we can make sure you get credit in the release notes.
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @dcereijodo |
|
Hey. I've updated the changelog accordingly. I've also submitted again the CLA, but it seems that the bot complained again. It's just this form a need to fill in and submit no? I anyways tried one more time. You can let me know here or in Slack if it's still not working.
|
|
@dcereijodo Thank you! After you submit, there's a second manual step on our end - should be all set now. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
hey @dcereijodo - based on your comment here (#2316 (comment)) this PR should be ready to go, right? If so, are you able to fix the merge conflict in the changelog? Once that's addressed, I think we'll be ready to ship this as-is |
|
@drewbanin it should be fine now. |
There was a problem hiding this comment.
Looks good to me, thanks for your contribution @dcereijodo!
resolves #2316
Description
Changed logger configuration to log
depends_on_nodesnode attribute when logging with theModelMetadatacontext.Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.