Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for non-json-serializable values in BigQuery nested columns #2348

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented Apr 21, 2020

resolves #2336

Description

Use the Decimal-aware json encoder when constructing an agate table from a nested BigQuery response

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Apr 21, 2020
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Have a suggestion on a missing quote, but that's it.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Jacob Beck <beckjake@users.noreply.github.com>
@drewbanin drewbanin merged commit f7b8e5c into dev/octavius-catto Apr 27, 2020
@drewbanin drewbanin deleted the fix/decimal-to-json-bq branch April 27, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run_sql command via dbt rpc returns Object of type Decimal is not JSON serializable
2 participants