Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2265
Description
On RPC calls, if the server detects that the final CLI
vars
calculated from--vars
are different from the server's CLI--vars
, rebuild the manifest.This will make those calls slower, because they have to build a manifest (and the partial parsing cache will be invalidated!).
I also moved the vars calculation from
set_config
(which happens in the main dispatching process) intohandle_request
(which happens in the RPC process). That fixed an issue where future calls had the wrongvars
once you made a call using--vars
(ugly!)I also split up the RPC tests, that file was getting crowded. That accounts for the vast majority of this change, I've noted the only new/changed test.
Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.