Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --no-browser argument to docs serve #2364

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Apr 27, 2020

resolves #2004

Description

This was hard to fix in any normal way, because python's webbrowser module doesn't provide any way to skip certain browsers or say "only use gui browsers". I just added a CLI flag that lets users disable attempting to open a tab at all.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Apr 27, 2020
@beckjake beckjake requested a review from drewbanin April 27, 2020 17:11
@beckjake beckjake merged commit 8bf5dd0 into dev/octavius-catto Apr 27, 2020
@beckjake beckjake deleted the feature/webbrowser-no-deadlock branch April 27, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If opening a new tab in the local web browser blocks, dbt deadlocks
2 participants