Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove location and information_schema.schematas query from catalog (#2320) #2382

Merged
merged 1 commit into from
May 1, 2020
Merged

remove location and information_schema.schematas query from catalog (#2320) #2382

merged 1 commit into from
May 1, 2020

Conversation

beckjake
Copy link
Contributor

resolves #2320

Description

This is pretty straightforward, we don't query the catalog for location anymore, which avoids hitting information_schema.schemata on bigquery.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Apr 30, 2020
@beckjake beckjake requested a review from drewbanin April 30, 2020 20:18
drewbanin
drewbanin approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@beckjake beckjake merged commit 6e1665d into dev/octavius-catto May 1, 2020
@beckjake beckjake deleted the fix/remove-bq-location branch May 1, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove query to information_schema.schemata in BigQuery catalog generation
2 participants
@beckjake @drewbanin