Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for changing snapshot strategy types #2391

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented May 2, 2020

resolves #2350

Description

Change timestamp strategy comparison to be resilient for changing snapshot strategies.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label May 2, 2020
@drewbanin drewbanin requested a review from beckjake May 2, 2020 16:40
@drewbanin
Copy link
Contributor Author

cc @jrandrews

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice tests :shipit:

@drewbanin drewbanin merged commit 24ed84d into fix/snapshot-staging-is-not-atomic May 4, 2020
@drewbanin drewbanin deleted the fix/snapshot-use-updated-at-timestamp-for-comparisons branch May 4, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants