fix source patching perf with no patches #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2474
Description
So, this is just about the lowest of low-hanging fruit possible, but this fix just makes dbt not bother going through the patch logic when there is no patch.
quick update: also, I fixed
finalize_and_validateto skip a serialization/deserialization step and to avoid double-validating.I'll keep looking at perf, but this gets us from 71.18s to
16.11s9.64s on a 676-source project.Checklist
This PR includes tests, ortests are not required/relevant for this PRCHANGELOG.mdand added information about my change to the "dbt next" section.