Fix parallel rpc methods (2484) #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 16, 2020 13:08
For the test to work, we have to switch to spawn so that we don't deadlock
beckjake
force-pushed
the
fix/parallel-rpc-method-stomping
branch
from
ebac510
to
12a9c2b
Compare
drewbanin
approved these changes
Jun 17, 2020
Closed
1 task
|
awesome! |
|
Hey folks, just chiming back here after a few months. Any more thought into restoring @beckjake, you mentioned the performance is degraded for really large manifests. Given that our compile_sql requests make use of macros, models, and sources (but not, say, tests, or analysis), do you have any suggestions on how we might prune the manifest for speedier compilations? Thanks! 🙇 |
|
Posted to hacker news today, might be relevant: https://gist.github.com/nicowilliams/a8a07b0fc75df05f684c23c18d7db234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2484
Description
This resolves the "parallel requests get the wrong arguments" issue described here, by deepcopying the arguments.
It resolves the hang/deadlock by switching to
spawninstead offork, which really hurts performance with medium/large manifests. Future patches will have to fix this, but the test hangs on a deadlock without it.Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.