bump requirements, enable the token cache #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
The changes here are totally reasonable. I haven't been able to test this out locally (Okta <> sandbox Snowflake). I'll get that set up for future version checks. I'm glad you were able to test it out, and I'll ask the OP from #2689 to test out the forthcoming release candidate.
gshank
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2613
resolves #2689
Description
Upgrade the snowflake-connector-python library and enable the token cache. We don't have a good way to test this currently, I think we'd need to set up a headless browser (I have no idea what the state of the art there is, I assume they still exist and it's not still selenium).
I did update the unit tests, but they won't save us if the library changes, so when we upgrade it we'll want to test this manually again.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.