Feature: state and defer in RPC calls #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Very nice work on the tests. I just tried locally and confirmed parity between cli_args and run + state/defer params.
I'm happy with merging this into v0.19.0, given there isn't much rush. We still need time to figure out state comparison in the Cloud IDE, anyway.
|
Ok. I opened this against 0.19.0 because we didn't have a 0.18.1 branch at the time - I can definitely point it there instead if you'd prefer, since I have to fix the changelog anyway. |
|
I'm happy with leaving it at 0.19, feels like part of taking these features out of beta |
jtcohen6
added
state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2678
Description
Added state and defer arguments to every RPC call whose matching CLI call has them.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.