Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add env vars with a magic prefix to the metadata #2785

Merged
merged 1 commit into from
Sep 24, 2020
Merged

add env vars with a magic prefix to the metadata #2785

merged 1 commit into from
Sep 24, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Sep 23, 2020 •
edited
Loading

resolves #2764

Description

Add the environment variable dict described in #2764 to the metadata dict.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Sep 23, 2020
@beckjake beckjake force-pushed the feature/metadata-env-vars branch 2 times, most recently from 8f8e5e6 to 83de891 Compare September 23, 2020 15:00
Base automatically changed from feature/invocation-id to feature/common-artifact-metadata September 23, 2020 15:06
@beckjake beckjake changed the base branch from feature/common-artifact-metadata to dev/kiyoshi-kuromiya September 23, 2020 16:04
@beckjake beckjake marked this pull request as ready for review September 23, 2020 16:04
jtcohen6
jtcohen6 approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

{"metadata": ..., "env": {"JERCO": "true"}}

neat! will definitely need to document this :)

@jtcohen6 jtcohen6 merged commit 19232f5 into dev/kiyoshi-kuromiya Sep 24, 2020
@jtcohen6 jtcohen6 deleted the feature/metadata-env-vars branch September 24, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshank gshank gshank approved these changes

@jtcohen6 jtcohen6 jtcohen6 approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom environment metadata in JSON artifacts
3 participants
@beckjake @gshank @jtcohen6