Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save args in run_results.json #2813

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Oct 5, 2020

resolves #2510

Description

Save cli arguments (or the equivalent for the RPC server) to run_results.json

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Oct 5, 2020
@gshank gshank force-pushed the feature/2510-save-args-run_results branch 4 times, most recently from 7407fb7 to a8cdc39 Compare October 5, 2020 22:22
@gshank
Copy link
Contributor Author

gshank commented Oct 5, 2020

RPC run_results args with just 'run':
"args": {
"log_format": "default",
"write_json": true,
"profiles_dir": "/Users/gerda/.dbt",
"use_cache": true,
"host": "0.0.0.0",
"port": 8580,
"version_check": true,
"which": "rpc"
}

cli dbt run_results args with just 'run':
"args": {
"log_format": "default",
"write_json": true,
"profiles_dir": "/Users/gerda/.dbt",
"use_cache": true,
"version_check": true,
"which": "run",
"rpc_method": "run"
}

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything working as expected.

It does seem odd to me that the RPC run method returns {"which": "rpc"}, whereas CLI dbt run returns {"which": "run", "rpc_method": "run"}. That's a matter out of scope for this particular issue, but worth addressing when we eventually get around to RPC <> CLI consistency.

@gshank
Copy link
Contributor Author

gshank commented Oct 6, 2020

I found the "which" and "rpc_method" thing a bit odd too. I looked into it, and the code has a bunch of methods specifying both in the CLI version (not the rpc code, which. has only the one that's been passed to it). And I wasn't quite sure of the purpose and wasn't sure if we'd lose information by removing, so I left it there.

@jtcohen6
Copy link
Contributor

jtcohen6 commented Oct 6, 2020

Yeah... I would like to rationalize those someday, but it's not in scope for this issue per se.

@gshank gshank force-pushed the feature/2510-save-args-run_results branch from a8cdc39 to 9472288 Compare October 8, 2020 21:39
@gshank gshank merged commit 3888e00 into dev/kiyoshi-kuromiya Oct 9, 2020
@kwigley kwigley deleted the feature/2510-save-args-run_results branch February 5, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

capture dbt cli submitted command in run_results.json
3 participants