add optional role argument, fix messaging around permissions errors
#291
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcarthur
commented
Feb 19, 2017
| @@ -3,7 +3,7 @@ | |||
| changed_tests := `git status --porcelain | grep '^\(M\| M\|A\| A\)' | awk '{ print $$2 }' | grep '\/test_[a-zA-Z_\-\.]\+.py'` | |||
|
|
|||
| install: | |||
| pip install . | |||
| pip install --upgrade . | |||
There was a problem hiding this comment.
it turns out this is needed for re-installation to work.
|
@cmcarthur can you update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds an optional
roleargument to profiles.yml, and also improves the messaging around faux 'This session does not have a current database' (actually lack of permissions) errors.Functionally tested with:
role: INVALID(invalidrole: SYSADMIN(valid, with CREATE permissions)role: PUBLIC(valid, but not enough permissions)no role (== SYSADMIN as that is my default role)