Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump werkzeug upper bound dependency constraint to include version 1.0 #3011

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Bump werkzeug upper bound dependency constraint to include version 1.0 #3011

merged 2 commits into from
Jan 20, 2021

Conversation

Bl3f
Copy link
Contributor

@Bl3f Bl3f commented Jan 13, 2021

This PR aim to upgrade the werkzeug upper bound dependency to fix the following issue #3010.

Description

As suggested #3010 (comment) I just change the upper bound of the constraint.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Jan 13, 2021
@jtcohen6 jtcohen6 changed the base branch from dev/kiyoshi-kuromiya to dev/0.19.1 January 19, 2021 10:09
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @Bl3f!

Let's try to ship this one in v0.19.1. We're planning for that to be a performance-only release, with no functional changes relative to v0.19.0. Given that this only bumps an upper bound (= no risk of a breaking change), and that it resolves a dependency conflict with Airflow 2.0, I feel comfortable and warranted making an exception. We'll still want extensive user testing from folks who use the RPC, both in and outside of the dbt Cloud IDE.

Could you update the Changelog:

  • Create a new ## dbt 0.19.1 (Release TBD) section with subsections for ### Under the hood and Contributors:
  • Move your change + contributor entries accordingly

@cla-bot
Copy link

cla-bot bot commented Jan 20, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Christophe Blefari.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla:yes label Jan 20, 2021
@cla-bot cla-bot bot added the cla:yes label Jan 20, 2021
@Bl3f
Copy link
Contributor Author

Bl3f commented Jan 20, 2021

Here we go @jtcohen6, I think I did what you asked. I did not added a release date for the 0.19.0 because I did not find one.

I'm sorry for the commit without the identity in between I change my computer setup since last time.

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bl3f!

@jtcohen6 jtcohen6 merged commit 6b34e8a into dbt-labs:dev/0.19.1 Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants