Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First time flow #439

Merged
merged 9 commits into from
May 25, 2017
Merged

First time flow #439

merged 9 commits into from
May 25, 2017
+270 −71

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented May 20, 2017 •
edited
Loading

  • make this page more useful
  • clean up sample.dbt_project.yml
  • clean up sample.profiles.yml
  • test on windows (cmd, powershell, git bash)
  • figure out what sys.platform is when running thru git bash on windows
    • win32 on cmd/powershell + git bash

For #77

@drewbanin drewbanin modified the milestone: 0.8.2 Release May 23, 2017
@drewbanin drewbanin requested a review from cmcarthur May 24, 2017 13:43
cmcarthur
cmcarthur reviewed May 24, 2017
View reviewed changes
Copy link
Member

@cmcarthur cmcarthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code looks fine. the only failure mode i'd be concerned about here is if there was some way to overwrite the existing profiles.yml file by running dbt init. if you're confident that won't happen, then :shipit:

@drewbanin
Copy link
Contributor Author

good looks @cmcarthur -- that can't happen with this code, but I'll add a unit test

@drewbanin drewbanin merged commit d15c0c6 into development May 25, 2017
@drewbanin drewbanin deleted the first-time-flow branch May 25, 2017 00:53
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
@drewbanin @iknox-fa
First time flow (#439)
a91411a 
* clone sample repo, better output after dbt init

* add default target to initial profiles file

* change starter project to fishtown repo

* pep8

* add `dbt debug --config-dir` cmd

* pep8

* sample file tweaks

* add overwrite check + unit test


automatic commit by git-black, original commits:
  d15c0c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmcarthur cmcarthur cmcarthur left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.2 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@drewbanin @cmcarthur