Feature/bq improvements #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
added
bigquery
enhancement
cmcarthur
requested changes
Aug 26, 2017
dbt/adapters/bigquery.py
Outdated
| @@ -111,6 +118,9 @@ def open_connection(cls, connection): | |||
| result = connection.copy() | |||
| credentials = connection.get('credentials', {}) | |||
|
|
|||
| if 'timeout_seconds' in credentials: | |||
| cls.QUERY_TIMEOUT = credentials['timeout_seconds'] | |||
There was a problem hiding this comment.
don't mutate global state. a better way:
- make
poll_until_job_completestake a timeout as an argument - then call it with
poll_until_job_completes(job, timeout=connection.get('credentials', {}).get('timeout_seconds'), cls.DEFAULT_QUERY_TIMEOUT)
There was a problem hiding this comment.
(and remove this logic altogether)
dbt/adapters/bigquery.py
Outdated
| query = client.run_sync_query(formatted_sql) | ||
| query.timeout_ms = cls.QUERY_TIMEOUT | ||
| query = client.run_sync_query(sql) | ||
| query.timeout_ms = cls.QUERY_TIMEOUT * 1000 |
There was a problem hiding this comment.
query timeout override is not respected here
cmcarthur
approved these changes
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query google sheets: #502
Add tables: #504