Refactor: split out parsers #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
changed the base branch from
development
to
faeture/improve-catalog-generation
|
@drewbanin is this just a refactor, or did you make changes to functionality here as well? |
|
@cmcarthur this is solely a refactor to split up the big |
cmcarthur
approved these changes
Jul 3, 2018
dbt/loader.py
Outdated
|
|
||
| from dbt.node_types import NodeType | ||
| from dbt.contracts.graph.parsed import ParsedManifest | ||
|
|
||
| from dbt.parser import ParserUtils | ||
| from dbt.parser import * |
There was a problem hiding this comment.
do you need this? i think you want just
import dbt.parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out parsers into different files. We'll need to do meaningful work on the schema test parser, and working in that file was hurting my soul.
Merge after #808