Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #816 and add tests. The issue is that when I migrated to the JSON schema validator I tried to preserve too much of the old without really understanding what I was doing. I think the right thing is to move some of the logic into the ValidationException, store the intermediate steps on that object, and do all this regex unpleasantness there to figure out what kind of validation issues we had so we can generate a nice message for the user.
The new validator also seems to sometimes repeat the same errors multiple times so I stripped duplicates.
The new error looks like this (two extra keys, two missing keys):
Is this obvious enough? Should we somehow try to make it more clear at this point that it's the profile that's probably wrong and not the
dbt_project.yml
file? The only line that we really can control without this turning into something huge is theExtra project configuration value(s)...
line. IsExtra profile configuration value(s)...
better? Or evenExtra connection configuration value(s) in profile ...
?