Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors on null schema (#980) #992

Merged
merged 2 commits into from
Sep 11, 2018
Merged

Fix errors on null schema (#980) #992

merged 2 commits into from
Sep 11, 2018

Conversation

beckjake
Copy link
Contributor

Fixes #980 by filtering null schemas out on the adapter level. We wouldn't allow null schemas in our manifest so we don't have to handle a node.schema is None scenario.

@drewbanin
Copy link
Contributor

does frozenset work in py2/py3?

@beckjake
Copy link
Contributor Author

Yup! frozenset has existed as long as set has.

drewbanin
drewbanin approved these changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool, LGTM

@beckjake beckjake merged commit 5c2fa70 into dev/lucretia-mott Sep 11, 2018
@beckjake beckjake deleted the fix/errors-on-null-schema branch September 11, 2018 20:42
This was referenced Sep 11, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beckjake @drewbanin