Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
pg_catalog
schema to all the base models to cope with the requirement of "late binding views" (with no schema binding) that all objects must be qualified by schema, e.g.from <schema>.<objectname>
rather than justfrom <objectname>
see #26
For consistency, I also added a base model
stv_partitions
, because the underlying system view was being directly referenced by theredshift_admin_table_stats
view.Testing
All of the models in the
./base
directory areephemeral
as specified in thedbt_project.yml
file, so they aren't directly tested by their instantiation, however, all of these base models are referenced by models in the./views
directory in this package which are instantiated. These views are effectively serving as integration tests when they are run.I ran this both with a global
bind: false
(all views will be created without schema binding) in thedbt_project.yml
file and without, and it now runs successfully with that specification.