Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

car-mirror: Specify the need to send graph roots in each round for push #15

Open
justindotpub opened this issue Oct 14, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@justindotpub
Copy link
Contributor

The following text currently appears in the Pull Protocol details, section 3.2.1.

Any available graph roots MUST be sent as an array ([CID]) by the Requestor, regardless of the Requestor's Bloom filter. These form the basis of subquery anchors in the session.

I do not see any similar statement for the Push Protocol in section 3.3.1, and my understanding is that graph roots must always be pushed in each round, regardless of bloom filters, to ensure that returned subgraph roots are not tainted by false positives.

I personally didn't even pick up on the significance of the statement in section 3.2.1 during my reading of the spec, and then I completely missed it when I started by focusing on implementing push and was ignoring the Pull sections of the spec.

@expede expede added the bug Something isn't working label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants