Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraCoreComponentPodConfig nesting error in deployment-template #39

Open
leonbrandt opened this issue Feb 28, 2021 · 0 comments
Open

Comments

@leonbrandt
Copy link

leonbrandt commented Feb 28, 2021

templates/deployment.yaml contains the following block at line 697:

---
{{- if .Values.kafka.authentication.tls.enabled }}
...
{{- end }}
{{- if .Values.extraCoreComponentPodConfig }}
{{ toYaml .Values.extraCoreComponentPodConfig | indent 6 -}}
{{- end }}

which leads to the generation of a single extraCoreComponentPodConfig-block after rendering the template whenever it is defined. I'm quite sure the extraCoreComponentPodConfig-block should be inside the kafka.authentication.tls.enabled-block above.


For example if my values-file contains this:

extraCoreComponentPodConfig:
  tolerations:
  - key: faas
    operator: Exists
    effect: NoSchedule

the rendered template will contain this:

---
# Source: fission-all/templates/deployment.yaml
tolerations:
      - effect: NoSchedule
        key: faas
        operator: Exists
---

which obviously isn't a valid kubernetes-object.

Tested in fission-all-1.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant