bugs with patches added by gaia-autolander are not displayed on "to check in"or "to fix" tabs after r+

[millermedeiros]

we started to use Autolander for gaia but bugzilla-todos doesn't handle it properly.

if I have a bug assigned to myself and Autolander creates the pull request, the bug disappears from the bugzilla todos app after r+, since it considers that Autolander is the responsible for doing the check-in - the correct behavior would be to keep the assignee as the responsible for the check-in.

Autolander documentation on MDN

---

edit: the bug does show up on "to nag" until reviewer r+ it.

[edmorley]

So to clarify: you have a bug with assignee X but patch creator Y, where the patch has r+ (presumably where requestee and setter are the same) but the bug doesn't show in X's "to check in" or "to fix"? Could you point at an example bug? :-)

[edmorley]

Ah I would have thought bugzilla-todos would have done something like "fetch all bugs assigned to X and iterate through patches on those bugs" but we actually just directly fetch all attachments uploaded by X regardless of whether they are assigned to the bug:
https://github.com/fitzgen/bugzilla-todos/blob/gh-pages/app/user.js#L173

It seems like the former would be a better approach in general - and several of the bugzilla queries could be combined (at the moment it makes separate queries for each of the tabs). However this isn't just a 2 line change, so not sure when someone might get a chance to look at this.

[millermedeiros]

example:

1. bug assigned to "foo@bar.com"; (displayed on "To Fix")
2. "foo@bar.com" creates a new pull request with the bug id in the title;
3. "bug.autolander@gmail.com" creates a pull request automatically;
4. assignee asks for review from "lorem@ipsum.com"; (displayed on "To Nag")
5. "lorem@ipsum.com" r+ the patch; (disappears from the app)