Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Integer overflow #139

Closed
2 of 4 tasks
stdiopt opened this issue Mar 19, 2024 · 6 comments · Fixed by #140
Closed
2 of 4 tasks

[Bug] Integer overflow #139

stdiopt opened this issue Mar 19, 2024 · 6 comments · Fixed by #140
Assignees
Labels
error:forced priority:p2 Affects most users; fix needed status:accepted Scoped and accepted into queue type:bug Something is broken or incorrect update_type:models Primary focus requires model updates

Comments

@stdiopt
Copy link

stdiopt commented Mar 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the issue

DBT transformation fails with an integer overflow most likely related to the cast to int where it could be dbt.type_bigint()?

https://github.com/fivetran/dbt_hubspot/blob/main/models/marketing/intermediate/int_hubspot__contact_merge_adjust.sql#L22

Relevant error log or model output

11:43:06
Database Error in model int_hubspot__contact_merge_adjust (models/marketing/intermediate/int_hubspot__contact_merge_adjust.sql)
11:43:06
Overflow (Integer valid range -2147483648 to 2147483647)
11:43:06
compiled Code at target/run/hubspot/models/marketing/intermediate/int_hubspot__contact_merge_adjust.sql

Expected behavior

No error in sync

What database are you using dbt with?

redshift

dbt Version

1.5.1

Are you willing to open a PR to help address this issue?

  • Yes.
  • Yes, but I will need assistance and will schedule time during our office hours for guidance
  • No.
@fivetran-jamie
Copy link
Collaborator

hey there @stdiopt thanks for taking the time to open this issue!

i think you're certainly right that we'll need to cast as a bigint. i've made the change in a testing branch if you'd like to test it out:

# packages.yml -- replace hubspot reference with the below
packages:
  - git: https://github.com/fivetran/dbt_hubspot.git
    revision: bug/cast-vid_to_merge-bigint
    warn-unpinned: false 

also i don't think this really changes things at all, but do you have the hubspot_contact_merge_audit_enabled variable set to true?

thanks!

@stdiopt
Copy link
Author

stdiopt commented Mar 19, 2024

Hey Jamie,

also i don't think this really changes things at all, but do you have the hubspot_contact_merge_audit_enabled variable set to true?

to be honest I'm not entirely sure since this is managed by fivetran and based on quickstart transformations, I just disabled those transformations now since I noticed that we aren't using it

@fivetran-jamie
Copy link
Collaborator

Ah ok, the hubspot_contact_merge_audit_enabled variable is false by default and I believe Quickstart wouldn't change it to true.

As for testing, since you're on Quickstart, we'll work to recreate the issue on our end, see if the cast as {{ dbt.type_bigint() }} does the trick, and prioritze the fix for an upcoming sprint 🤠

@fivetran-reneeli
Copy link
Contributor

Hi @stdiopt , we have been able to recreate the error and find the fix on our end. We'll be including this fix in our upcoming sprint, so keep an eye out for a new release!

@fivetran-joemarkiewicz fivetran-joemarkiewicz added priority:p2 Affects most users; fix needed type:bug Something is broken or incorrect status:accepted Scoped and accepted into queue update_type:models Primary focus requires model updates labels Apr 4, 2024
@fivetran-reneeli fivetran-reneeli self-assigned this Apr 8, 2024
@fivetran-reneeli fivetran-reneeli mentioned this issue Apr 8, 2024
17 tasks
@fivetran-reneeli fivetran-reneeli linked a pull request Apr 12, 2024 that will close this issue
17 tasks
@EPNickBosma
Copy link

🙏 this is currently biting us -- any indication of when 0.17.1 might be released please?

@fivetran-reneeli
Copy link
Contributor

Hi @EPNickBosma , thanks for the patience-- we've just merged the branch with fix, so expect the release within the next few hours!

cc @stdiopt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error:forced priority:p2 Affects most users; fix needed status:accepted Scoped and accepted into queue type:bug Something is broken or incorrect update_type:models Primary focus requires model updates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants