Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add type_id to DEAL_COMPANY and DEAL_CONTACT #106

Closed
2 of 4 tasks
fivetran-catfritz opened this issue May 8, 2023 · 0 comments · Fixed by #110 or fivetran/dbt_hubspot#112
Closed
2 of 4 tasks

[Feature] Add type_id to DEAL_COMPANY and DEAL_CONTACT #106

fivetran-catfritz opened this issue May 8, 2023 · 0 comments · Fixed by #110 or fivetran/dbt_hubspot#112
Assignees
@fivetran-catfritz
Labels
priority:p3 Affects many users; can wait status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality

Comments

@fivetran-catfritz
Copy link
Contributor

fivetran-catfritz commented May 8, 2023 •
edited
Loading

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

In the May 2023 connector update type_id was added to DEAL_COMPANY and DEAL_CONTACT as a part of the composite primary key for these tables. This column needs to be added to the corresponding models.

Also from the update, columns updated_at and created_at were added to several tables. Those should incorporated as well.

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response
@fivetran-catfritz fivetran-catfritz self-assigned this Jun 1, 2023
@fivetran-catfritz fivetran-catfritz added priority:p3 Affects many users; can wait type:enhancement New functionality or enhancement status:in_progress Currently being worked on update_type:feature Primary focus is to add new functionality labels Jun 1, 2023
@fivetran-catfritz fivetran-catfritz mentioned this issue Jun 6, 2023
Merged
18 tasks
@fivetran-catfritz fivetran-catfritz linked a pull request Jun 7, 2023 that will close this issue
Feature/add typeid #109
Merged
18 tasks
@fivetran-catfritz fivetran-catfritz mentioned this issue Jun 7, 2023
Merged
18 tasks
@fivetran-catfritz fivetran-catfritz linked a pull request Jun 7, 2023 that will close this issue
Feature/add typeid fivetran/dbt_hubspot#111
Merged
18 tasks
This was unlinked from pull requests Jun 8, 2023
Feature/add typeid fivetran/dbt_hubspot#111
Merged
Feature/add typeid #109
Merged
@fivetran-catfritz fivetran-catfritz linked a pull request Jun 8, 2023 that will close this issue
Release/v0.10.0 #110
Merged
@fivetran-jamie fivetran-jamie linked a pull request Jun 8, 2023 that will close this issue
Releases/v0.10.latest fivetran/dbt_hubspot#112
Merged
18 tasks
@fivetran-jamie fivetran-jamie mentioned this issue Jun 8, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fivetran-catfritz fivetran-catfritz

Labels
priority:p3 Affects many users; can wait status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release/v0.10.0 fivetran/dbt_hubspot_source
Releases/v0.10.latest fivetran/dbt_hubspot
1 participant
@fivetran-catfritz