Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Understanding Snowflake and tmp view models #116

Closed
2 of 4 tasks
fivetran-catfritz opened this issue Oct 4, 2023 · 2 comments
Closed
2 of 4 tasks

[Feature] Understanding Snowflake and tmp view models #116

fivetran-catfritz opened this issue Oct 4, 2023 · 2 comments
Assignees
Labels
priority:p3 Affects many users; can wait status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates

Comments

@fivetran-catfritz
Copy link
Contributor

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Continuing discussions from this slack thread and this one, this issue is for a deeper investigation into this.

The problem arises in Snowflake when a source's dimensions changes, but the dbt model has been run again.

The proposed solution is to update our tmp view models is to use dbt_utils.star at least for Snowflake targets.

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@reubster
Copy link

reubster commented Oct 6, 2023

"The problem arises in Snowflake when a source's dimensions changes, but the dbt model has not yet been run again."

@fivetran-catfritz .. responding to your Slack question;

"In Snowflake, are you also persisting docs, or does this happen regardless?"

Went to look up what you meant by "persisting docs". I didn't know that was a feature in dbt. No, we're not using it.

When I look at the view definition in Snowflake, Snowflake has 'materialised' the column names of the view... but still has the same select * from body.

Seems a straightforward fix to itemise the columns at dbt-run using dbt_utils.star

image

@fivetran-joemarkiewicz
Copy link
Contributor

Hi @reubster I would agree with you that we can ideally solve this with a dbt_utils.star in the tmp models.

My team is planning to pick this up for hubspot in the coming sprint (starting 10/18). However, if you need an immediate fix for this I noticed you are open to creating a PR. If you would like to open a PR I would be more than happy to review your PR and integrate your changes into the next release of the HubSpot package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p3 Affects many users; can wait status:in_progress Currently being worked on type:enhancement New functionality or enhancement update_type:models Primary focus requires model updates
Projects
None yet
Development

No branches or pull requests

3 participants