Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Incoprorate Historical Schedule Changes #158

Closed
2 of 4 tasks
fivetran-jamie opened this issue Jun 4, 2024 · 9 comments
Closed
2 of 4 tasks

[Feature] Incoprorate Historical Schedule Changes #158

fivetran-jamie opened this issue Jun 4, 2024 · 9 comments
Assignees
Labels
type:enhancement New functionality or enhancement

Comments

@fivetran-jamie
Copy link
Contributor

fivetran-jamie commented Jun 4, 2024

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Account for changes made to schedule start/end times by using the audit_log source table. Work has been started in #157 and fivetran/dbt_zendesk_source#50 but the logic in the schedule_spine model needs to be updated to include the new code

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-jamie fivetran-jamie added the enhancement New feature or request label Jun 4, 2024
@dkang1023
Copy link

@fivetran-jamie Hi Jamie, we are a Fivetran customer and looking to rely on this feature for critical business reporting. What's the current status of this, and are we able to get this prioritized? Let me know and thank you so much.

@fivetran-joemarkiewicz
Copy link
Contributor

Hi @dkang1023 we are actually committing to this as a feature update in our upcoming quarter (starting next week). I estimate we will have a working version ready by mid September.

@dkang1023
Copy link

Hi @fivetran-joemarkiewicz - I wanted to check-in here and confirm we should expect a fix in the upcoming weeks in September? Let me know and thanks again.

@fivetran-catfritz
Copy link
Contributor

fivetran-catfritz commented Sep 5, 2024

Hi @dkang1023 I will picking up this ticket. The updates are a bit complex, so the goal is to have this finished around the end of September!

@fivetran-catfritz fivetran-catfritz self-assigned this Sep 5, 2024
@fivetran-catfritz fivetran-catfritz added type:enhancement New functionality or enhancement and removed enhancement New feature or request labels Sep 5, 2024
@robabramowitz
Copy link

hi @fivetran-catfritz - I wanted to check in and see if you would be able to provide an estimated ETA on this. Thank you very much for all of the support!

@fivetran-catfritz
Copy link
Contributor

Hi @robabramowitz thank you for checking in! And good timing--I am currently working on this and hope to have a test branch available in the next couple days.

@fivetran-catfritz
Copy link
Contributor

Hi @dkang1023 and @robabramowitz I have created a test branch with the updates to bring in historical schedules.

If you would like to install it and try it out, you can add the following code in place of the existing zendesk in your packages.yml.

- git: https://github.com/fivetran/dbt_zendesk.git
  revision: feature/historical-schedules
  warn-unpinned: false

Let me how this works for you! If things are working out, this will move on to release.

@dkang1023
Copy link

@fivetran-catfritz Thank you - we are doing validation checks on our end. I see that it has already been pushed to release, so we will follow up with our findings. Thank you for the patience.

@fivetran-joemarkiewicz
Copy link
Contributor

This update has since been rolled out in the latest version of the package. As such, I will close out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New functionality or enhancement
Projects
None yet
Development

No branches or pull requests

5 participants