You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@LWisteria When the source and destination of copy_from_device_async() are both device memory objects (cl_mem), should it raise an error, or execute EnqueueCopyBuffer just as in copy_from_device()?
@ybsh I understand that your question is about clpy itself but not about this issue. If you suggest raising an error on copy_from_device() (and also on _async), please make an issue for it.
@LWisteria
Thank you for your advice, and sorry that was off-topic.
Aside from the error handling issue above, I think it is necessary to migrate CuPy's Event/Stream classes first, as those async family take a CUDA stream as one of their arguments.
Do you agree? If you do, could I open an issue for that?
Currently, all async memory operation are implemented as sync.
clpy/clpy/backend/memory.pyx
Lines 300 to 301 in 3fd3b23
clpy/clpy/backend/memory.pyx
Lines 335 to 336 in 3fd3b23
clpy/clpy/backend/memory.pyx
Lines 407 to 408 in 3fd3b23
clpy/clpy/backend/memory.pyx
Lines 432 to 433 in 3fd3b23
They are should be implemented as async.
The text was updated successfully, but these errors were encountered: