環境変数TOKENを設定したときに正しいクエリでアクセスすると定期処理ができるテスト

Author: ogawa-tomo

app/controllers/scheduler_controller.rb

@@ -8,7 +8,6 @@ class SchedulerController < ApplicationController
   protected
 
   def require_token
-    return if Rails.env.test?
     return if ENV['TOKEN'].present? && ENV['TOKEN'] == params[:token]
 
     head :unauthorized

test/application_system_test_case.rb

@@ -8,6 +8,8 @@
 require 'supports/report_helper'
 require 'supports/comment_helper'
 require 'supports/tag_helper'
+require 'supports/query_helper'
+require 'supports/mock_env_helper'
 
 class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
   include LoginHelper
@@ -17,6 +19,8 @@ class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
   include ReportHelper
   include CommentHelper
   include TagHelper
+  include QueryHelper
+  include MockEnvHelper
 
   if ENV['HEADED']
     driven_by :selenium, using: :chrome

test/supports/mock_env_helper.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module MockEnvHelper
+  def mock_env(partial_env_hash)
+    old = ENV.to_hash
+    ENV.update partial_env_hash
+    begin
+      yield
+    ensure
+      ENV.replace old
+    end
+  end
+end

test/supports/query_helper.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module QueryHelper
+  def visit_with_query(url, query_hash)
+    uri = URI.parse(url)
+    uri.query = query_hash.to_query
+    visit uri.to_s
+  end
+end

test/system/auto_retire_test.rb

@@ -16,7 +16,9 @@ class AutoRetireTest < ApplicationSystemTestCase
     user = users(:kyuukai)
     travel_to Time.zone.local(2020, 7, 2, 0, 0, 0) do
       VCR.use_cassette 'subscription/update' do
-        visit scheduler_daily_auto_retire_path
+        mock_env({ 'TOKEN' => 'token' }) do
+          visit_with_query scheduler_daily_auto_retire_path, { token: 'token' }
+        end
       end
       assert_equal Date.current, user.reload.retired_on
     end
@@ -49,7 +51,9 @@ class AutoRetireTest < ApplicationSystemTestCase
     user = users(:kyuukai)
     travel_to Time.zone.local(2020, 7, 1, 0, 0, 0) do
       VCR.use_cassette 'subscription/update' do
-        visit scheduler_daily_auto_retire_path
+        mock_env({ 'TOKEN' => 'token' }) do
+          visit_with_query scheduler_daily_auto_retire_path, { token: 'token' }
+        end
       end
       assert_nil user.reload.retired_on
     end
@@ -64,7 +68,9 @@ class AutoRetireTest < ApplicationSystemTestCase
     logout
 
     travel_to Time.zone.local(2020, 7, 2, 0, 0, 0) do
-      visit scheduler_daily_auto_retire_path
+      mock_env({ 'TOKEN' => 'token' }) do
+        visit_with_query scheduler_daily_auto_retire_path, { token: 'token' }
+      end
       assert_nil user.reload.retired_on
     end
   end
@@ -76,7 +82,9 @@ class AutoRetireTest < ApplicationSystemTestCase
     user.update!(retired_on: retired_date)
 
     travel_to Time.zone.local(2020, 7, 2, 0, 0, 0) do
-      visit scheduler_daily_auto_retire_path
+      mock_env({ 'TOKEN' => 'token' }) do
+        visit_with_query scheduler_daily_auto_retire_path, { token: 'token' }
+      end
       assert_equal retired_date, user.reload.retired_on
     end
   end
@@ -89,7 +97,9 @@ class AutoRetireTest < ApplicationSystemTestCase
 
     travel_to Time.zone.local(2020, 7, 2, 0, 0, 0) do
       VCR.use_cassette 'subscription/update' do
-        visit scheduler_daily_auto_retire_path
+        mock_env({ 'TOKEN' => 'token' }) do
+          visit_with_query scheduler_daily_auto_retire_path, { token: 'token' }
+        end
       end
       assert_equal Date.current, user.reload.retired_on
     end
@@ -106,7 +116,9 @@ class AutoRetireTest < ApplicationSystemTestCase
     travel_to Time.zone.local(2020, 7, 2, 0, 0, 0) do
       Discord::Server.stub(:delete_text_channel, true) do
         VCR.use_cassette 'subscription/update' do
-          visit scheduler_daily_auto_retire_path
+          mock_env({ 'TOKEN' => 'token' }) do
+            visit_with_query scheduler_daily_auto_retire_path, { token: 'token' }
+          end
         end
       end
       assert_equal Date.current, user.reload.retired_on
@@ -123,7 +135,9 @@ class AutoRetireTest < ApplicationSystemTestCase
       UserMailer.stub(:auto_retire, stub_postmark_error) do
         travel_to Time.zone.local(2020, 7, 2, 0, 0, 0) do
           VCR.use_cassette 'subscription/update' do
-            visit scheduler_daily_auto_retire_path
+            mock_env({ 'TOKEN' => 'token' }) do
+              visit_with_query scheduler_daily_auto_retire_path, { token: 'token' }
+            end
           end
           assert_equal Date.current, user.reload.retired_on
         end
@@ -140,7 +154,9 @@ class AutoRetireTest < ApplicationSystemTestCase
 
     travel_to Time.zone.local(2020, 7, 2, 0, 0, 0) do
       VCR.use_cassette 'subscription/update' do
-        visit scheduler_daily_auto_retire_path
+        mock_env({ 'TOKEN' => 'token' }) do
+          visit_with_query scheduler_daily_auto_retire_path, { token: 'token' }
+        end
       end
       assert_equal Date.current, user.reload.retired_on
     end

test/system/notification/questions_test.rb

@@ -303,15 +303,19 @@ class Notification::QuestionsTest < ApplicationSystemTestCase
     )
 
     travel_to Time.zone.local(2022, 11, 6, 0, 0, 0) do
-      visit '/scheduler/daily/notify_certain_period_passed_after_last_answer'
+      mock_env({ 'TOKEN' => 'token' }) do
+        visit_with_query scheduler_daily_notify_certain_period_passed_after_last_answer_path, { token: 'token' }
+      end
       visit_with_auth '/notifications', 'kimura'
 
       assert_no_text 'Q&A「テストの質問」のベストアンサーがまだ選ばれていません。'
     end
     logout
 
     travel_to Time.zone.local(2022, 11, 7, 0, 0, 0) do
-      visit '/scheduler/daily/notify_certain_period_passed_after_last_answer'
+      mock_env({ 'TOKEN' => 'token' }) do
+        visit_with_query scheduler_daily_notify_certain_period_passed_after_last_answer_path, { token: 'token' }
+      end
       visit_with_auth '/notifications', 'kimura'
 
       assert_text 'Q&A「テストの質問」のベストアンサーがまだ選ばれていません。'