Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css-modules #21

Closed
Kotpes opened this issue May 24, 2017 · 7 comments
Closed

css-modules #21

Kotpes opened this issue May 24, 2017 · 7 comments
Assignees

Comments

@Kotpes
Copy link

Kotpes commented May 24, 2017

Great module! Any plans making it work with css-modules out of the box?

@fkhadra
Copy link
Owner

fkhadra commented May 24, 2017

Hey @Kotpes appreciate. I'll think about it, it can be a good idea

@fkhadra fkhadra self-assigned this May 24, 2017
@fkhadra fkhadra added this to the v1.7.1 milestone Jun 7, 2017
@fkhadra fkhadra modified the milestones: v1.7.2, v1.7.1 Jun 18, 2017
@fkhadra fkhadra removed this from the v1.7.2 milestone Jul 12, 2017
@fkhadra
Copy link
Owner

fkhadra commented Jul 21, 2017

Any good example to make it works with css module ?

@Kotpes
Copy link
Author

Kotpes commented Jul 21, 2017

Yeah, react-day-picker supports it: http://react-day-picker.js.org/docs/styling.html
Essentially, introduce a new prop, e.g. classNames.

@fkhadra
Copy link
Owner

fkhadra commented Jul 21, 2017

Thanks ! Got a starting point 👍

@fkhadra
Copy link
Owner

fkhadra commented Jul 21, 2017

@Kotpes from what I understand, all I need to do is to expose a className property right ?

@Kotpes
Copy link
Author

Kotpes commented Jul 21, 2017

For <ToastContainer /> component, yes, looks like it will do the trick

@fkhadra
Copy link
Owner

fkhadra commented Jul 21, 2017

Actually the ToastContainer already accept a className property.
But I Will also give a way to set the className for toast and toast body

@fkhadra fkhadra closed this as completed Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants