Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: v5 changelog missing. #336

Closed
SimonSchick opened this issue Apr 8, 2019 · 11 comments
Closed

Meta: v5 changelog missing. #336

SimonSchick opened this issue Apr 8, 2019 · 11 comments
Assignees

Comments

@SimonSchick
Copy link

Can you post those please? :)

@fkhadra
Copy link
Owner

fkhadra commented Apr 9, 2019

Hey @SimonSchick,

What do you mean by the meta ? Are you talking about the RC ?

Thanks

@SimonSchick
Copy link
Author

I used meta in this context since it's not an issue with the package itself.
Also is it still an RC? You published v5.0.0 which doesn't look like an RC. 😛

@fkhadra
Copy link
Owner

fkhadra commented Apr 9, 2019

I understand now 😁 . I'll do that ASAP.

This is the stable release that is published now.

@ksocha
Copy link

ksocha commented Apr 11, 2019

What's the breaking change?

@fkhadra
Copy link
Owner

fkhadra commented Apr 11, 2019

Hello @ksocha,

There is no breaking change from the v4 to v5. The bump to the major version number is due to the fact that I updated the build tools.

  • @babel/runtime is a new dependency. This help reduce bundle size
  • Single file build just like react and react-router.
  • Add a pre-optimized production builds.
  • Add esm modules. The lib is now "tree-shakable"

@fkhadra fkhadra self-assigned this Apr 11, 2019
@SimonSchick
Copy link
Author

@fkhadra something must have changed, toasts no longer work, the CSS is not bundled correctly anymore.

@fkhadra
Copy link
Owner

fkhadra commented Apr 11, 2019

@SimonSchick could you share your issue on codesanbox ? It's working for me: https://codesandbox.io/s/k2jv5x1k1v?fontsize=14

@SimonSchick
Copy link
Author

Not having a whole lot of luck boiling it down.
But I think it's #334

@fkhadra
Copy link
Owner

fkhadra commented Apr 11, 2019

@SimonSchick can you share your project ? Or at least a minimal repo with that issue.

EDIT: I'll try right know with a CRA build
Thank you

@fkhadra
Copy link
Owner

fkhadra commented Apr 11, 2019

@SimonSchick not issue with CRA when I built it.

@SimonSchick
Copy link
Author

@fkhadra again, it's the same issue as #334 we have changed nothing in our project, I'm going to close this issue in favor of 334.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants