Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to flip compare/diff highlighting #1239

Open
soxrok2212 opened this issue Jul 25, 2024 · 4 comments
Open

Add ability to flip compare/diff highlighting #1239

soxrok2212 opened this issue Jul 25, 2024 · 4 comments

Comments

@soxrok2212
Copy link

Feature description

When I compare old_firmware and new_firmware, often times the diffing code shows old_firmware as having the new changes as indicated by the highlighting.

It would be handy to be able to reverse this so the diff highlights the changes in the new_firmware instead.

@jstucke
Copy link
Collaborator

jstucke commented Jul 26, 2024

You mean the (text) diff between two files and not the firmware comparison page, right? One (arguably not very practical) way to achieve that is to switch IDs in the URL. It should be easy to add a button that does that. I will take a look.

@soxrok2212
Copy link
Author

soxrok2212 commented Jul 26, 2024

You mean the (text) diff between two files and not the firmware comparison page, right?

Yes! I actually did try flipping the IDs in the URL and each time it went back to the original.

@jstucke
Copy link
Collaborator

jstucke commented Aug 1, 2024

You mean the (text) diff between two files and not the firmware comparison page, right?

Yes! I actually did try flipping the IDs in the URL and each time it went back to the original.

To be more specific:

  • It does not work on the comparison page (i.g. /compare/<uid1>;<uid2>)
  • but it should work on the text file diff page (i.e. /comparison/text_files/<uid1>/<uid2>)

@soxrok2212
Copy link
Author

You mean the (text) diff between two files and not the firmware comparison page, right?

Yes! I actually did try flipping the IDs in the URL and each time it went back to the original.

To be more specific:

  • It does not work on the comparison page (i.g. /compare/<uid1>;<uid2>)
  • but it should work on the text file diff page (i.e. /comparison/text_files/<uid1>/<uid2>)

Ah, this does work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants