You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.
I wouldn't consider this a bug, but an enhancement.
Be aware that, depending on how far this project is used by the community, that removing the inherited class may result in a BC break. Other users of Magento2-Flysystem might use these inherited classes in type hints. Please be sure to use a correct semantic version, if this gets merged.
since this is the only class where "unnesessary" class inheritation is still used and there is a core class (\Magento\Cms\Block\Adminhtml\Wysiwyg\Images\Content\Uploader) which i used as pattern for my class which does it the same way. I'm not anymore sure if this should be changed.
Describe the bug
There are classes inside the project that are created by class inheritance. While this was an code style mostly used in Magento1, and should'nt still be used in Magento2, the class, and other classes written like this, should be changed to the Object composition pattern.
https://devdocs.magento.com/guides/v2.3/ext-best-practices/extension-coding/common-programming-bp.html#composition-over-inheritance
F.e the
Flagbit\Flysystem\Block\Adminhtml\Filesystem\Content\Uploader
class should be changed, regarding to this.The text was updated successfully, but these errors were encountered: