feat: allowed specifying renderBody via constructor #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
approved these changes
Apr 14, 2022
| }) : super(priority: priority) { | ||
| this.paint = paint ?? (Paint()..color = defaultColor); | ||
| } | ||
|
|
||
| static const defaultColor = Color.fromARGB(255, 255, 255, 255); |
There was a problem hiding this comment.
I think we can skip this one and rely on the default color of HasPaint
There was a problem hiding this comment.
I think we should do this on another PR since this would be a breaking change. In addition, it is out of the scope of the PR.
There was a problem hiding this comment.
Sounds good, I was thinking of it since you did some changes to paint in this PR too
There was a problem hiding this comment.
Oopsy. Did I change something? I believe I only reordered the constructor to be right after the class declaration.
|
Just the merge conflict that needs to be solved, other than that I think this is ready to be merged! |
auto-merge was automatically disabled
April 15, 2022 07:56
Head branch was pushed to by a user without write access
spydon
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows setting
renderBodyvia constructor.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues