Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: MoveAlongPathEffect can now be applied to any PositionProvider #1555

Merged
merged 5 commits into from
Apr 20, 2022
Merged

feat: MoveAlongPathEffect can now be applied to any PositionProvider #1555

merged 5 commits into from
Apr 20, 2022

Conversation

st-pasha
Copy link
Contributor

Description

  • The MoveAlongPathEffect is now derived from the MoveEffect base class, and can be given an explicit target.
  • The effect can now be applied to any PositionProvider.
  • An exception will be thrown if oriented: true flag is given, but the target is not an AngleProvider.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

@spydon spydon enabled auto-merge (squash) April 20, 2022 17:57
@spydon spydon merged commit a0ff2d1 into flame-engine:main Apr 20, 2022
@st-pasha st-pasha deleted the ps/move-along-path-effect branch April 20, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@luanpotter luanpotter Awaiting requested review from luanpotter

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@st-pasha @spydon @wolfenrain