Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Anchor equality operator is now more reliable #1560

Merged
merged 1 commit into from
Apr 21, 2022
Merged

fix: Anchor equality operator is now more reliable #1560

merged 1 commit into from
Apr 21, 2022

Conversation

st-pasha
Copy link
Contributor

Description

Comparing hashcodes may return that two different Anchors are equal with a small probability. This has now been fixed.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@st-pasha st-pasha mentioned this pull request Apr 21, 2022
Merged
6 tasks
@spydon spydon merged commit 0d6581e into flame-engine:main Apr 21, 2022
@st-pasha st-pasha deleted the ps/anchor branch April 21, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st-pasha @spydon