Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Organize Component class #1608

Merged
merged 15 commits into from
May 8, 2022
Merged

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented May 6, 2022

Description

Over time, the Component class became quite disorganized.
In this PR I move around various methods/properties of the Component class so that methods that perform related functions would be next to each other; classifying them into several named regions.

Also, updated doc-comment for the class, because that was obviously long overdue.

No functions/methods/properties were removed or modified.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • [-] I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

@spydon spydon merged commit 069294f into flame-engine:main May 8, 2022
@st-pasha st-pasha deleted the ps/component branch May 8, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants