Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve tests #1609

Merged
merged 9 commits into from
May 8, 2022
Merged

refactor: Improve tests #1609

merged 9 commits into from
May 8, 2022

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented May 7, 2022

Description

  • Modernize various tests (helper classes made private, proper name of test groups, use testWithFlameGame where appropriate, test for assert failure messages);
  • For some tests improved coverage;
  • Fixed bug with ParentIsA mixin, where wrong parent triggered a TypeCast error instead of an assertion error. The corresponding test couldn't catch this because it tried to call onMount manually instead of actually mounting the component, and the error was thrown before the mounting stage.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

WIP for #1351

@st-pasha st-pasha changed the title Ps/tests refactor: Improve tests May 7, 2022
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there no withX.test left now?

@st-pasha
Copy link
Contributor Author

st-pasha commented May 8, 2022

Are there no withX.test left now?

There are probably quite a few remains -- it takes time to go over every test.

@spydon spydon enabled auto-merge (squash) May 8, 2022 14:48
@spydon spydon merged commit f33b398 into flame-engine:main May 8, 2022
@st-pasha st-pasha deleted the ps/tests branch May 8, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants